chore(mcu): C-14a — delete dead ADF4382A EZSync surface

Production firmware never used SYNC_METHOD_EZSYNC — both callsites
(main.cpp:938 recovery, main.cpp:1955 boot) pass SYNC_METHOD_TIMED.
The original audit C-14 flagged TX/RX SPI skew in EZSync's trigger
sequence, but the path was dead from production; only test_bug3
referenced it for spy-harness regression coverage.

Removed:
  - SYNC_METHOD_EZSYNC enum value
  - ADF4382A_SetupEZSync function (and declaration)
  - ADF4382A_TriggerEZSync function (and declaration)
  - EZSync branch in ADF4382A_Manager_Init (collapsed to unconditional
    SetupTimedSync call)
  - test_bug3_timed_sync_noop.c Test C (EZSync regression coverage)

Production header and test shim header both cleaned. SyncMethod enum
kept as single-value to avoid touching the 7 other test callers that
pass SYNC_METHOD_TIMED.

Residual concern (separate from original C-14): ADF4382A_TriggerTimedSync
uses the same TX-then-RX sw_sync SPI sequencing pattern as the deleted
EZSync trigger. ~5 µs SPI gap between TX-armed and RX-armed means TX
and RX may capture different SYNCP/SYNCN edges (60 MHz cycle = 16.7 ns,
~300 edges in the gap). External SYNCP only provides simultaneity if
both devices are armed before a common edge. Hardware bench-test
required to confirm operational tolerance; cannot fix in firmware
without DMA SPI burst rewrite.

Regression: 86/0 (matches baseline).

9_Firmware/9_1_Microcontroller/9_1_1_C_Cpp_Libraries/adf4382a_manager.c

@@ -184,18 +184,14 @@ int ADF4382A_Manager_Init(ADF4382A_Manager *manager, SyncMethod method)
     adf4382_set_en_chan(manager->rx_dev, 0, true);
     adf4382_set_en_chan(manager->rx_dev, 1, false);
     
-    // Mark initialized BEFORE sync setup so SetupTimedSync/SetupEZSync
+    // SetupTimedSync is a public API (also callable post-init); it gates
-    // see initialized=true and actually configure the hardware.
+    // on `initialized=true`. Mark the manager initialized here — the SPI
-    // (FIX for Bug #1: previously this was set AFTER the sync calls,
+    // is up and both ADF4382A devices are configured, so a public API
-    //  causing them to always return -2 NOT_INIT.)
+    // call is legitimate. Roll back to false on sync-setup failure so the
+    // manager isn't left half-configured.
     manager->initialized = true;
     DIAG("LO", "manager->initialized set to true (before sync setup)");
 
-    // Setup synchronization based on selected method
-    DIAG("LO", "About to call sync setup -- manager->initialized=%s",
-              manager->initialized ? "true" : "false");
-
-    if (method == SYNC_METHOD_TIMED) {
     ret = ADF4382A_SetupTimedSync(manager);
     DIAG("LO", "ADF4382A_SetupTimedSync() returned %d", ret);
     if (ret) {
@@ -204,19 +200,8 @@ int ADF4382A_Manager_Init(ADF4382A_Manager *manager, SyncMethod method)
         manager->initialized = false;
         return ret;
     }
-    } else {
-        ret = ADF4382A_SetupEZSync(manager);
-        DIAG("LO", "ADF4382A_SetupEZSync() returned %d", ret);
-        if (ret) {
-            DIAG_ERR("LO", "EZSync setup FAILED: %d", ret);
-            printf("EZSync setup failed: %d\n", ret);
-            manager->initialized = false;
-            return ret;
-        }
-    }
 
-    printf("ADF4382A Manager initialized with %s synchronization on SPI4\n",
+    printf("ADF4382A Manager initialized with TIMED synchronization on SPI4\n");
-           (method == SYNC_METHOD_TIMED) ? "TIMED" : "EZSYNC");
     
     DIAG_ELAPSED("LO", "Total Manager_Init", t_start);
     DIAG("LO", "Init returning OK (sync setup %s)",
@@ -265,44 +250,6 @@ int ADF4382A_SetupTimedSync(ADF4382A_Manager *manager)
     return ADF4382A_MANAGER_OK;
 }
 
-int ADF4382A_SetupEZSync(ADF4382A_Manager *manager)
-{
-    int ret;
-    
-    DIAG("LO", "SetupEZSync called, manager=%p initialized=%s",
-         (void*)manager, (manager ? (manager->initialized ? "true" : "false") : "N/A"));
-
-    if (!manager || !manager->initialized) {
-        DIAG_ERR("LO", "SetupEZSync REJECTED: %s",
-                 !manager ? "NULL manager" : "not initialized (initialized=false)");
-        return ADF4382A_MANAGER_ERROR_NOT_INIT;
-    }
-    
-    printf("Setting up EZSync (SPI-based synchronization)...\n");
-
-    // Setup TX for EZSync
-    ret = adf4382_set_ezsync_setup(manager->tx_dev, true);
-    DIAG("LO", "TX adf4382_set_ezsync_setup() returned %d", ret);
-    if (ret) {
-        printf("TX EZSync setup failed: %d\n", ret);
-        return ret;
-    }
-    
-    // Setup RX for EZSync
-    ret = adf4382_set_ezsync_setup(manager->rx_dev, true);
-    DIAG("LO", "RX adf4382_set_ezsync_setup() returned %d", ret);
-    if (ret) {
-        printf("RX EZSync setup failed: %d\n", ret);
-        return ret;
-    }
-    
-    manager->sync_method = SYNC_METHOD_EZSYNC;
-    printf("EZSync configured\n");
-    DIAG("LO", "EZSync setup complete for both TX and RX");
-    
-    return ADF4382A_MANAGER_OK;
-}
-
 int ADF4382A_TriggerTimedSync(ADF4382A_Manager *manager)
 {
     int ret;
@@ -358,55 +305,6 @@ int ADF4382A_TriggerTimedSync(ADF4382A_Manager *manager)
     return ADF4382A_MANAGER_OK;
 }
 
-int ADF4382A_TriggerEZSync(ADF4382A_Manager *manager)
-{
-    int ret;
-    
-    if (!manager || !manager->initialized || manager->sync_method != SYNC_METHOD_EZSYNC) {
-        DIAG_ERR("LO", "TriggerEZSync REJECTED");
-        return ADF4382A_MANAGER_ERROR_NOT_INIT;
-    }
-
-    DIAG("LO", "Triggering EZSync via SPI...");
-
-    // Trigger software sync on both devices
-    ret = adf4382_set_sw_sync(manager->tx_dev, true);
-    if (ret) {
-        DIAG_ERR("LO", "TX sw_sync SET failed: %d", ret);
-        printf("TX software sync failed: %d\n", ret);
-        return ADF4382A_MANAGER_ERROR_SPI;
-    }
-
-    ret = adf4382_set_sw_sync(manager->rx_dev, true);
-    if (ret) {
-        DIAG_ERR("LO", "RX sw_sync SET failed: %d", ret);
-        printf("RX software sync failed: %d\n", ret);
-        return ADF4382A_MANAGER_ERROR_SPI;
-    }
-    
-    // Small delay for sync to take effect
-    no_os_udelay(10);
-
-    // Clear software sync
-    ret = adf4382_set_sw_sync(manager->tx_dev, false);
-    if (ret) {
-        DIAG_ERR("LO", "TX sw_sync CLEAR failed: %d", ret);
-        printf("TX sync clear failed: %d\n", ret);
-        return ADF4382A_MANAGER_ERROR_SPI;
-    }
-    
-    ret = adf4382_set_sw_sync(manager->rx_dev, false);
-    if (ret) {
-        DIAG_ERR("LO", "RX sw_sync CLEAR failed: %d", ret);
-        printf("RX sync clear failed: %d\n", ret);
-        return ADF4382A_MANAGER_ERROR_SPI;
-    }
-
-    printf("EZSync triggered via SPI\n");
-    DIAG("LO", "EZSync trigger complete (set + 10us + clear)");
-    return ADF4382A_MANAGER_OK;
-}
-
 int ADF4382A_Manager_Deinit(ADF4382A_Manager *manager)
 {
     if (!manager || !manager->initialized) {

9_Firmware/9_1_Microcontroller/9_1_1_C_Cpp_Libraries/adf4382a_manager.h

@@ -52,7 +52,6 @@
 #define ADF4382A_MANAGER_ERROR_SPI       -3
 
 typedef enum {
-    SYNC_METHOD_EZSYNC = 0,      // Software synchronization via SPI
     SYNC_METHOD_TIMED = 1        // Hardware synchronization via SYNCP/SYNCN
 } SyncMethod;
 
@@ -71,9 +70,7 @@ typedef struct {
 int ADF4382A_Manager_Init(ADF4382A_Manager *manager, SyncMethod method);
 int ADF4382A_Manager_Deinit(ADF4382A_Manager *manager);
 int ADF4382A_SetupTimedSync(ADF4382A_Manager *manager);
-int ADF4382A_SetupEZSync(ADF4382A_Manager *manager);
 int ADF4382A_TriggerTimedSync(ADF4382A_Manager *manager);
-int ADF4382A_TriggerEZSync(ADF4382A_Manager *manager);
 int ADF4382A_CheckLockStatus(ADF4382A_Manager *manager, bool *tx_locked, bool *rx_locked);
 int ADF4382A_SetOutputPower(ADF4382A_Manager *manager, uint8_t tx_power, uint8_t rx_power);
 int ADF4382A_EnableOutputs(ADF4382A_Manager *manager, bool tx_enable, bool rx_enable);

9_Firmware/9_1_Microcontroller/tests/shims/adf4382a_manager.h

@@ -64,7 +64,6 @@
 #define ADF4382A_MANAGER_ERROR_SPI       -3
 
 typedef enum {
-    SYNC_METHOD_EZSYNC = 0,
     SYNC_METHOD_TIMED = 1
 } SyncMethod;
 
@@ -83,9 +82,7 @@ typedef struct {
 int ADF4382A_Manager_Init(ADF4382A_Manager *manager, SyncMethod method);
 int ADF4382A_Manager_Deinit(ADF4382A_Manager *manager);
 int ADF4382A_SetupTimedSync(ADF4382A_Manager *manager);
-int ADF4382A_SetupEZSync(ADF4382A_Manager *manager);
 int ADF4382A_TriggerTimedSync(ADF4382A_Manager *manager);
-int ADF4382A_TriggerEZSync(ADF4382A_Manager *manager);
 int ADF4382A_CheckLockStatus(ADF4382A_Manager *manager, bool *tx_locked, bool *rx_locked);
 int ADF4382A_SetOutputPower(ADF4382A_Manager *manager, uint8_t tx_power, uint8_t rx_power);
 int ADF4382A_EnableOutputs(ADF4382A_Manager *manager, bool tx_enable, bool rx_enable);

9_Firmware/9_1_Microcontroller/tests/test_bug3_timed_sync_noop.c

@@ -5,15 +5,15 @@
  * messages but performed no hardware action.
  *
  * Fix: Implemented a sw_sync pulse (set true → 10us delay → set false) on
- * both TX and RX devices, mirroring EZSync's trigger pattern. With
+ * both TX and RX devices. With timed_sync_setup already programmed, the
- * timed_sync_setup already programmed, the devices synchronize their output
+ * devices synchronize their output dividers to the SYNCP/SYNCN clock edge
- * dividers to the SYNCP/SYNCN clock edge when sw_sync is asserted.
+ * when sw_sync is asserted.
  *
  * Test strategy (post-fix):
  *   1. Initialize manager with SYNC_METHOD_TIMED.
  *   2. Reset spy log, call TriggerTimedSync().
  *   3. Verify 4 SPY_ADF4382_SET_SW_SYNC records (TX set, RX set, TX clear,
- *      RX clear) — same count as EZSync.
+ *      RX clear).
  *   4. Verify the set/clear ordering is correct.
  ******************************************************************************/
 #include "adf4382a_manager.h"
@@ -83,19 +83,7 @@ int main(void)
     assert(sw_idx == 4);
     printf("  PASS: Ordering is correct (set TX, set RX, clear TX, clear RX)\n");
 
-    /* ---- Test C: Compare with EZSync — both should produce 4 sw_sync calls ---- */
-    mgr.sync_method = SYNC_METHOD_EZSYNC;
-    spy_reset();
-    ret = ADF4382A_TriggerEZSync(&mgr);
-    assert(ret == ADF4382A_MANAGER_OK);
-    int ezsync_count = spy_count_type(SPY_ADF4382_SET_SW_SYNC);
-    printf("\n  EZSync sw_sync count: %d (expected 4, same as timed sync)\n",
-           ezsync_count);
-    assert(ezsync_count == 4);
-    printf("  PASS: Both sync methods now issue the same hw trigger pattern\n");
-
     /* Cleanup */
-    mgr.sync_method = SYNC_METHOD_TIMED;
     ADF4382A_Manager_Deinit(&mgr);
 
     printf("\n=== Bug #3: ALL TESTS PASSED (post-fix) ===\n\n");