Mirrors/NawfalMotii79-PLFM_RADAR
1
0
Fork 0
mirror of https://github.com/NawfalMotii79/PLFM_RADAR.git synced 2026-06-10 07:27:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

AUDIT-S12: parameterize output_bin_count zero-literals in range_bin_decimator

Browse Source 
`output_bin_count` is declared `reg [RP_RANGE_BIN_WIDTH_MAX-1:0]`
(9 bits on 50T, 12 bits on 200T), but the reset and ST_IDLE assignments
used the literal `9'd0`. Vivado zero-extends with a width-mismatch
warning on 200T. The FORMAL port `fv_output_bin_count` was also
hardcoded `[8:0]`.

Replace all three sites with `{RP_RANGE_BIN_WIDTH_MAX{1'b0}}` /
parameterized port width — same pattern already used for the
`range_bin_index` reset in this module.

No functional change. Verified by full FPGA regression: 41/41 PASS,
0 lint errors (Range Bin Decimator: 63 checks PASS).
This commit is contained in:
Jason
2026-04-30 09:04:01 +05:45
parent bb6952753d
commit e97e55dd63
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
9_Firmware/9_2_FPGA/range_bin_decimator.v
+3 -3
View File
@@ -67,7 +67,7 @@ module range_bin_decimator #(
output wire [2:0] fv_state, output wire [2:0] fv_state,
output wire [10:0] fv_in_bin_count, output wire [10:0] fv_in_bin_count,
output wire [1:0] fv_group_sample_count, output wire [1:0] fv_group_sample_count,
output wire [8:0] fv_output_bin_count, output wire [`RP_RANGE_BIN_WIDTH_MAX-1:0] fv_output_bin_count,
output wire [10:0] fv_skip_count output wire [10:0] fv_skip_count
`endif `endif
); );
@@ -143,7 +143,7 @@ always @(posedge clk or negedge reset_n) begin
state <= ST_IDLE; state <= ST_IDLE;
in_bin_count <= 11'd0; in_bin_count <= 11'd0;
group_sample_count <= 2'd0; group_sample_count <= 2'd0;
output_bin_count <= 9'd0; output_bin_count <= {`RP_RANGE_BIN_WIDTH_MAX{1'b0}};
skip_count <= 11'd0; skip_count <= 11'd0;
watchdog_count <= 10'd0; watchdog_count <= 10'd0;
watchdog_timeout <= 1'b0; watchdog_timeout <= 1'b0;
@@ -170,7 +170,7 @@ always @(posedge clk or negedge reset_n) begin
ST_IDLE: begin ST_IDLE: begin
in_bin_count <= 11'd0; in_bin_count <= 11'd0;
group_sample_count <= 2'd0; group_sample_count <= 2'd0;
output_bin_count <= 9'd0; output_bin_count <= {`RP_RANGE_BIN_WIDTH_MAX{1'b0}};
skip_count <= 11'd0; skip_count <= 11'd0;
watchdog_count <= 10'd0; watchdog_count <= 10'd0;
peak_i <= 16'd0; peak_i <= 16'd0;