Mirrors/NawfalMotii79-PLFM_RADAR
1
0
Fork 0
mirror of https://github.com/NawfalMotii79/PLFM_RADAR.git synced 2026-06-10 15:31:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(gui): GUI-S2 — DataRecorder snapshots arrays before HDF5 write

Browse Source 
The same RadarFrame is enqueued for the display consumer and handed to
DataRecorder.record_frame on the producer thread. h5py releases the GIL
during gzip compression, so any in-place mutation by the consumer (or a
future scaling/normalisation step) would tear the on-disk frame.

record_frame now copies all five numpy arrays into local snapshots
before passing them to h5py.create_dataset. Disk integrity no longer
depends on consumer behaviour.

New test test_record_frame_isolates_from_post_call_mutation asserts
that mutating every array in place after record_frame returns leaves
the HDF5 contents untouched.

Tests: GUI 93/93 (was 92), ruff clean repo-wide.
This commit is contained in:
Jason
2026-04-27 12:37:03 +05:45
parent ca2b6e527d
commit 760288037f
2 changed files with 58 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
9_Firmware/9_3_GUI/radar_protocol.py
+15 -5
View File
@@ -679,16 +679,26 @@ class DataRecorder:
def record_frame(self, frame: RadarFrame):
if not self._recording or self._file is None:
return
# GUI-S2: snapshot the arrays before handing them to h5py. The same
# frame object is also queued for the display consumer, and h5py
# releases the GIL during gzip compression — without this copy, any
# in-place mutation by the consumer (or a future scaling/normalization
# step) would tear the on-disk frame.
try:
mag = np.asarray(frame.magnitude).copy()
rdi = np.asarray(frame.range_doppler_i).copy()
rdq = np.asarray(frame.range_doppler_q).copy()
det = np.asarray(frame.detections).copy()
rprf = np.asarray(frame.range_profile).copy()
fg = self._grp.create_group(f"frame_{self._frame_count:06d}")
fg.attrs["timestamp"] = frame.timestamp
fg.attrs["frame_number"] = frame.frame_number
fg.attrs["detection_count"] = frame.detection_count
fg.create_dataset("magnitude", data=frame.magnitude, compression="gzip")
fg.create_dataset("range_doppler_i", data=frame.range_doppler_i, compression="gzip")
fg.create_dataset("range_doppler_q", data=frame.range_doppler_q, compression="gzip")
fg.create_dataset("detections", data=frame.detections, compression="gzip")
fg.create_dataset("range_profile", data=frame.range_profile, compression="gzip")
fg.create_dataset("magnitude", data=mag, compression="gzip")
fg.create_dataset("range_doppler_i", data=rdi, compression="gzip")
fg.create_dataset("range_doppler_q", data=rdq, compression="gzip")
fg.create_dataset("detections", data=det, compression="gzip")
fg.create_dataset("range_profile", data=rprf, compression="gzip")
self._frame_count += 1
except (OSError, ValueError, TypeError) as e:
log.error(f"Recording error: {e}")